Skip to content

fix: NFT collection name #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hanjano merged 1 commit into from
Sep 11, 2024
Merged

fix: NFT collection name #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion blockapi/test/v2/api/nft/test_simple_hash.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def test_parse_nfts(requests_mock, api, nfts_response):
assert data.contract == '4d5b1ef2d87f2212c7b00300296439da'
assert data.standard == 'ordinals'
assert data.name == 'Bitcoin Frog #7825'
assert not data.collection_name
assert data.collection_name == 'Bitcoin Frogs'
assert not data.description
assert (
data.image_url
Expand Down
1 change: 1 addition & 0 deletions blockapi/v2/api/nft/simple_hash.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ def _yield_parsed_nfts_from_tokens(self, items, address):
yield NftToken.from_api(
ident=ident,
collection=collection_id,
collection_name=collection.get('name'),
contract=collection_id,
standard=standard,
name=item.get('name') or contract.get('name'),
Expand Down