Conversation
galvanizze
approved these changes
Oct 11, 2022
Comment on lines
+83
to
+85
| """ | ||
| Class for handling blockchain API services with customizable base URL. | ||
| """ |
Member
There was a problem hiding this comment.
please add example of common cases (RPC services, testnet alternatives, ...)
Co-authored-by: galvanizze <marek.galvanek@gmail.com>
ladovina
reviewed
Oct 11, 2022
| e.g. proxy, testnet, RPC services, alternative sources | ||
| """ | ||
|
|
||
| API_BASE_URL: str = NotImplemented |
Contributor
There was a problem hiding this comment.
nitpick: I though this is wrong so I investigated what happens when you use just NotImplemented, looks it works fine (I thought the var will just contain <class NotImplemented> (which is not)... it was not clear to me in the official doc: https://docs.python.org/3/library/constants.html#NotImplemented but this was better: https://s16h.medium.com/pythons-notimplemented-type-2d720137bf41
tldr: probably use of property with raise NotImplementedError would be probably better
ladovina
approved these changes
Oct 11, 2022
hanjano
added a commit
that referenced
this pull request
Oct 11, 2022
Co-authored-by: galvanizze <marek.galvanek@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.