refactor(node): split client core wiring#787
Conversation
Extract persistence, endpoint, and support helpers from NodeClientCore. Route FCP/TMCI/toadlet access through ClientEndpoints and add helper wiring for client context resources. Update tests and FCP/HTTP callers to use the new accessors.
Add Javadoc to clarify startup sequencing and error cases. Add tests for throttle persistence, disk checker, and context wiring.
Add a dedicated lock for persistence alert validity.\nAdd NodeClientCoreSupport unit coverage.
Convert NodeClientCoreInit to a record carrier and expand its Javadoc. Update core initialization call sites to use record accessors. Add a unit test covering stored references and null handling.
Expand Javadoc to clarify lifecycle and threading expectations. Publish optional endpoint refs via AtomicReference and add unit tests covering accessors and create() wiring.
Convert the resource holder to a record while preserving accessors. Expand Javadoc to be doclint-clean and add tests for getter/null cases.
Add long-form API docs for public/protected members and clarify lifecycle, threading, and policy details. Localize temp/persistent filename generators to constructor scope without changing behavior.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
src/main/java/network/crypta/node/TextModeClientInterfaceServer.java
Outdated
Show resolved
Hide resolved
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Return direct TMCI from endpoint creation and start it only after NodeClientCore publishes endpoints to avoid null access during console.directEnabled startup. Update tests to reflect deferred registration.
Extract transfer operations and policy handling into dedicated helpers to reduce NodeClientCore dependencies. Update call sites and tests to use getTransfers() access.
Add JUnit/Mockito coverage for allowlist registration and\npermission checks.\n\nExpand NodeClientCoreTransferPolicy Javadoc to satisfy doclint.
Add NodeClientCoreTransfers tests for get/put paths and reinserts.\nExpand NodeClientCoreTransfers Javadoc for doclint compliance.
Add long-form Javadoc for public APIs and clarify configuration, alert, and insert helpers to satisfy doclint.
Add lifecycle, threading, and policy details across public APIs.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Avoid NPEs when TMCI config callbacks run before endpoints are assigned.
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
1 participant
Summary
Testing