new: added vcs support for git#5
Merged
cryptaliagy merged 5 commits intomasterfrom Dec 17, 2020
Merged
Conversation
cryptaliagy
force-pushed
the
feat/vcs-support
branch
from
2c3fc16 to
9859db1
Compare
Collaborator
There was a problem hiding this comment.
All looking correct!
On the vcs.py and abc.py files, why not use python's ABC metaclasses instead of only raising NotImplementedError()
Owner
Author
|
Habit mostly lmao. Gonna keep this live until I add the .gitignore integration into this as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR resolves #1 and resolves #2