Add Makefile generation during project creation#8
Merged
andrewnags merged 2 commits intomasterfrom Mar 2, 2021
Merged
Conversation
When creating a project, generate a Makefile with targets for the - linter/formatter - type checker - test framework so that the user can use the same commands uniformly across frameworks. For example, a user wouldn't need to know if a krait-generated project used `unittest`, `pytest`, `nose`, etc. -- the user need only type `make test` at the command prompt and the generated target will perform the appropriate action.
cryptaliagy
approved these changes
Mar 2, 2021
Owner
cryptaliagy
left a comment
cryptaliagy
left a comment
There was a problem hiding this comment.
lgtm, one small nit but otherwise feel free to merge
Co-authored-by: Natalia Maximo <iam@natalia.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating a project, generate a Makefile with targets for the
so that the user can use the same commands uniformly across frameworks.
For example, a user wouldn't need to know if a krait-generated
project used
unittest,pytest,nose, etc. -- the user need onlytype
make testat the command prompt and the generated target willperform the appropriate action.
Note that the user will have to upgrade with
krait upgradefor the required template files to be copied;
pip install -U kraitwon't work.