Conversation
| with: | ||
| aws_access_key_id: ${{ secrets.AWS_LAMBDA_ACCESS_KEY_ID }} | ||
| aws_secret_access_key: ${{ secrets.AWS_LAMBDA_SECRET_ACCESS_KEY }} | ||
| aws_region: ${{ secrets.AWS_LAMBDA_REGION }} |
Contributor
There was a problem hiding this comment.
region is not a secret can be hard coded to "us-east-1"
function_name can also be hardocded to some placeholder name as it is not a secret like `cryptlexStripeIntegrationLambda
Member
Author
There was a problem hiding this comment.
This is just an example script as per the README.md.
Contributor
There was a problem hiding this comment.
This is a public repo, so it is better to be semantically correct
adnan-kamili
requested changes
Dec 19, 2024
Contributor
adnan-kamili
left a comment
adnan-kamili
left a comment
There was a problem hiding this comment.
please check comments
docs: AT permissions
adnan-kamili
approved these changes
Dec 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.