fix(tui): fill candle gaps for illiquid instruments#3
Merged
Conversation
…as continuous series Illiquid instruments (e.g. RWA perps) omit candlestick periods with zero trading activity. The renderer previously drew them as empty columns, producing a visibly broken/gapped chart. Pre-process candles with a carry-forward fill so missing periods render as a flat dim line at the previous close price. - Add `fill_candle_gaps(candles, interval_ms)`: pure function that inserts synthetic zero-volume candles (O=H=L=C=prev_close) for each missing period. - Detect synthetic candles in `render_chart_panel` via the (volume==0, open==close, high==low) sentinel and draw a full-cell horizontal bar on the matching price row so adjacent fill cells merge into one line. - Apply in the three chart paths: MarketTab detail (`ViewMode::Chart`), MarketTab compare (`ViewMode::Compare`), and the split-screen 1h chart in `app.rs`. - Tests cover gap insertion, contiguous no-op, and empty/single inputs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fill_candle_gaps(candles, interval_ms)inwidgets::candlestick— a pure function that inserts synthetic zero-volume, O=H=L=C=prev_close candles for each missing period.MarketTab::ViewMode::Chart,MarketTab::ViewMode::Compare, and the split-screen 1h chart inApp.Test plan
cargo test -p cdcx-tui --lib candlestick)cargo fmt --all --check+cargo clippy --locked --all-features -- -D warnings