Skip to content

Problem: build fail without cgo#549

Merged
yihuang merged 3 commits intocrypto-org-chain:developfrom
yihuang:develop
Oct 30, 2024
Merged

Problem: build fail without cgo#549
yihuang merged 3 commits intocrypto-org-chain:developfrom
yihuang:develop

Conversation

@yihuang
Copy link
Copy Markdown

@yihuang yihuang commented Oct 30, 2024

Description

Support CGO_ENABLED=0 make build


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@yihuang yihuang requested a review from mmsqe October 30, 2024 07:38
Comment thread CHANGELOG.md Outdated
yihuang added 2 commits October 30, 2024 15:38
Signed-off-by: yihuang <huang@crypto.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.16%. Comparing base (ce5773e) to head (7f2d861).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
app/ante/eip712.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #549   +/-   ##
========================================
  Coverage    46.16%   46.16%           
========================================
  Files          181      181           
  Lines        18125    18125           
========================================
  Hits          8368     8368           
  Misses        9040     9040           
  Partials       717      717           
Files with missing lines Coverage Δ
app/ante/eip712.go 59.42% <50.00%> (ø)

@yihuang yihuang enabled auto-merge (squash) October 30, 2024 07:55
@yihuang yihuang merged commit 885530b into crypto-org-chain:develop Oct 30, 2024
@yihuang yihuang deleted the develop branch October 31, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants