Problem: wrong gas price when using basefee of minus one height when trace tx#559
Merged
mmsqe merged 4 commits intocrypto-org-chain:developfrom Nov 12, 2024
Merged
Problem: wrong gas price when using basefee of minus one height when trace tx#559mmsqe merged 4 commits intocrypto-org-chain:developfrom
mmsqe merged 4 commits intocrypto-org-chain:developfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #559 +/- ##
===========================================
- Coverage 46.21% 46.20% -0.02%
===========================================
Files 181 181
Lines 18132 18146 +14
===========================================
+ Hits 8380 8384 +4
- Misses 9036 9043 +7
- Partials 716 719 +3
|
yihuang
reviewed
Nov 12, 2024
yihuang
left a comment
There was a problem hiding this comment.
As we discussed in slack, the root cause should be that we need to emulate begin blocker logic to recreate correct context for tracing execution, right?
Signed-off-by: mmsqe <tqd0800210105@gmail.com>
Author
I don't find good way to fill the empty consensus params, and get basefee is simpler. |
yihuang
approved these changes
Nov 12, 2024
yihuang
pushed a commit
that referenced
this pull request
Nov 13, 2024
* Problem: incorrect balance when no tracer in predecessors (#558) * Problem: incorrect balance when no tracer in predecessors * lint * Problem: wrong gas price when using basefee of minus one height when trace tx (#559) * Problem: wrong gas price when using basefee of minus one height when trace tx * add basefee req --------- Signed-off-by: mmsqe <tqd0800210105@gmail.com> * fix test --------- Signed-off-by: mmsqe <tqd0800210105@gmail.com>
yihuang
pushed a commit
that referenced
this pull request
Nov 14, 2024
…trace tx (#559) * Problem: wrong gas price when using basefee of minus one height when trace tx * add basefee req --------- Signed-off-by: mmsqe <tqd0800210105@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)