Skip to content

feat: add gas cap for grpc eth_call#666

Merged
thomas-nguy merged 2 commits intocrypto-org-chain:developfrom
thomas-nguy:thomas/port-gas-cap-eth-call
Jul 14, 2025
Merged

feat: add gas cap for grpc eth_call#666
thomas-nguy merged 2 commits intocrypto-org-chain:developfrom
thomas-nguy:thomas/port-gas-cap-eth-call

Conversation

@thomas-nguy
Copy link
Copy Markdown

Closes: #XXX

Description

add gas cap to prevent exploit


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

* add max gas cap in eth_call

* move logic
@thomas-nguy thomas-nguy requested a review from a team as a code owner July 14, 2025 08:55
@thomas-nguy thomas-nguy requested review from JayT106 and XinyuCRO and removed request for a team July 14, 2025 08:55
@thomas-nguy thomas-nguy changed the title feat: add gas cap for grpc eth_call (#586) feat: add gas cap for grpc eth_call Jul 14, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.85%. Comparing base (3b0e16c) to head (ef258e9).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #666      +/-   ##
===========================================
- Coverage    45.86%   45.85%   -0.01%     
===========================================
  Files          182      182              
  Lines        18198    18196       -2     
===========================================
- Hits          8346     8344       -2     
  Misses        9136     9136              
  Partials       716      716              
Files with missing lines Coverage Δ
x/evm/types/tx_args.go 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown

@songgaoye songgaoye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thomas-nguy thomas-nguy merged commit 59fc191 into crypto-org-chain:develop Jul 14, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants