Skip to content

fix: estimate gas missing fields for new tx type#680

Merged
thomas-nguy merged 2 commits intocrypto-org-chain:developfrom
thomas-nguy:thomas/estimate-gas-bug
Jul 31, 2025
Merged

fix: estimate gas missing fields for new tx type#680
thomas-nguy merged 2 commits intocrypto-org-chain:developfrom
thomas-nguy:thomas/estimate-gas-bug

Conversation

@thomas-nguy
Copy link
Copy Markdown

Closes: #XXX

cherry-pick cosmos/evm#316


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@thomas-nguy thomas-nguy requested a review from a team as a code owner July 31, 2025 01:44
@thomas-nguy thomas-nguy requested review from calvinaco and songgaoye and removed request for a team July 31, 2025 01:44
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.78%. Comparing base (83ae12e) to head (abd0b84).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #680      +/-   ##
===========================================
- Coverage    45.82%   45.78%   -0.04%     
===========================================
  Files          182      182              
  Lines        18218    18206      -12     
===========================================
- Hits          8348     8336      -12     
  Misses        9152     9152              
  Partials       718      718              
Files with missing lines Coverage Δ
x/evm/keeper/grpc_query.go 73.50% <100.00%> (-0.55%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@songgaoye
Copy link
Copy Markdown

The develop branch uses geth 1.11, so it's normal. If using geth 1.15, which supports the 7702 transaction type, it has bugs?

@thomas-nguy
Copy link
Copy Markdown
Author

thomas-nguy commented Jul 31, 2025

Yes, it does not affect our version yet but I think this change make it easier for future upgrade. We don't need to touch the other fields, just set the gas to correct value

@thomas-nguy thomas-nguy merged commit d2951a8 into crypto-org-chain:develop Jul 31, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants