fix: estimate gas missing fields for new tx type#680
Merged
thomas-nguy merged 2 commits intocrypto-org-chain:developfrom Jul 31, 2025
Merged
fix: estimate gas missing fields for new tx type#680thomas-nguy merged 2 commits intocrypto-org-chain:developfrom
thomas-nguy merged 2 commits intocrypto-org-chain:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #680 +/- ##
===========================================
- Coverage 45.82% 45.78% -0.04%
===========================================
Files 182 182
Lines 18218 18206 -12
===========================================
- Hits 8348 8336 -12
Misses 9152 9152
Partials 718 718
🚀 New features to boost your workflow:
|
|
The develop branch uses geth 1.11, so it's normal. If using geth 1.15, which supports the 7702 transaction type, it has bugs? |
Author
|
Yes, it does not affect our version yet but I think this change make it easier for future upgrade. We don't need to touch the other fields, just set the gas to correct value |
songgaoye
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
cherry-pick cosmos/evm#316
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)