Skip to content

Fix search and settings#736

Merged
dreacot merged 4 commits intocrypto-power:masterfrom
vufon:fix-search-and-settings
Mar 11, 2025
Merged

Fix search and settings#736
dreacot merged 4 commits intocrypto-power:masterfrom
vufon:fix-search-and-settings

Conversation

@vufon
Copy link
Copy Markdown
Contributor

@vufon vufon commented Mar 5, 2025

Resolves #731 Resolves #732

Details:

  • Fixed bug that could not be entered into search editor on tx history page
  • Fixed a bug where warnings text were not reflected immediately when selecting exchange options in Fetch Exchange Rate settings
  • When saving exchange settings. If the exchange gets rate failed and automatically switches to another valid exchange, give a warning dialog about this change
  • Fix logic when automatically switching to another valid exchange

Demo:

settings.fixed.mp4
mobile.mp4

Screenshot:

warning

Copy link
Copy Markdown
Member

@dreacot dreacot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@dreacot dreacot merged commit 2a6ac55 into crypto-power:master Mar 11, 2025
vufon added a commit to vufon/cryptopower that referenced this pull request Mar 11, 2025
* fix search editor error cannot be entered on PC

* (settings) Fix warning text display delay when selecting exchange

* display a warning when the exchange settings have been changed automatically because the rate is not getted

* update outdated version on workflow
dreacot pushed a commit that referenced this pull request Mar 11, 2025
…e when rescaning (#737)

* fix progress bar not working when rescan blockchain

* Change error message when trying to rescan

* Fix search and settings (#736)

* fix search editor error cannot be entered on PC

* (settings) Fix warning text display delay when selecting exchange

* display a warning when the exchange settings have been changed automatically because the rate is not getted

* update outdated version on workflow
vufon added a commit to vufon/cryptopower that referenced this pull request Mar 11, 2025
* fix search editor error cannot be entered on PC

* (settings) Fix warning text display delay when selecting exchange

* display a warning when the exchange settings have been changed automatically because the rate is not getted

* update outdated version on workflow
dreacot pushed a commit that referenced this pull request Mar 12, 2025
…tener structure between parent and subpage (#733)

* update balance and transaction list when new tx/block is registered

* update outdated version on workflow

* Fix search and settings (#736)

* fix search editor error cannot be entered on PC

* (settings) Fix warning text display delay when selecting exchange

* display a warning when the exchange settings have been changed automatically because the rate is not getted

* update outdated version on workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some issues when setting up Fetch Exchange Rate Cannot select and type in the Search bar on the transaction list

2 participants