fix missing upload of parties.conf#29
Closed
lenerd wants to merge 1 commit into
Closed
Conversation
These lines got lost in ef6ef8a.
Contributor
|
Fixed at #24 |
4 tasks
Contributor
|
Hi Lennart, I uploaded this line again, it's probably deleted by mistake. Lior |
Contributor
|
Hi, |
Contributor
Author
|
Hi Lior, I understand that. The problem is that these lines are missing for the case of an external protocol without a coordinator. In that case, every party gets the same configuration file whether multiple regions are used or not (line 123). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This readds the lines lost in ef6ef8a. See #24 (comment).
I am not completely sure about the
len(regions) > 1case and have not tested that.