Release 1.18.0

[cryptobot]

Important

Todos:

• Update build instructions
• Check for JDK update
• Check for JFX update

[coderabbitai]

Walkthrough

Bumps Cryptomator pkgver from 1.17.1 to 1.18.0 and updates .SRCINFO and PKGBUILD source URLs to the 1.18.0 release. Replaces embedded OpenJFX artifact from openjfx-24.0.1.zip to openjfx-25.zip. Updates all sha256sum entries for the new release and adjusts PKGBUILD jlink add-modules (adds jdk.crypto.ec and jdk.crypto.cryptoki and reorganizes module list). Other metadata (pkgbase, pkgrel, arch, dependencies, options, validpgpkeys) remains unchanged.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Mixed changes: version and checksum updates plus a small but non-trivial change to jlink module list.
• Review focus:
  • PKGBUILD: verify jlink --add-modules changes and any downstream effects.
  • PKGBUILD and .SRCINFO: confirm updated source URLs and sha256sums match official release artifacts.
  • OpenJFX artifact name change (openjfx-25.zip) and any dependent filenames/paths.

Possibly related PRs

• Release: 1.17.0 #15 — Updates PKGBUILD to bump Cryptomator and adjust embedded JDK/OpenJFX and jlink/jpackage build logic (strongly related).
• Release 1.13.0 #7 — Prior version bump that updated package version, source URLs, and checksums in PKGBUILD and .SRCINFO.

Suggested reviewers

• SailReal

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Release 1.18.0' directly corresponds to the main change: bumping the package version from 1.17.1 to 1.18.0 across all configuration files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check	✅ Passed	The pull request description lists checklist items related to build instructions and dependency updates, which directly align with the changeset modifications to version numbers and build modules.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch release/1.18.0

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ee767c3 and 2595cf8.

📒 Files selected for processing (2)

• .SRCINFO (2 hunks)
• PKGBUILD (3 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2024-06-26T09:11:54.167Z

Learnt from: infeo
Repo: cryptomator/aur PR: 7
File: .SRCINFO:23-24
Timestamp: 2024-06-26T09:11:54.167Z
Learning: Checksum values in the `.SRCINFO` file of the `cryptomator` repository are not API keys and should not be flagged as potential security issues.

Applied to files:

• PKGBUILD
• .SRCINFO

🔇 Additional comments (5)

PKGBUILD (3)

61-61: Good addition of crypto modules.

The addition of jdk.crypto.ec (Elliptic Curve cryptography) and jdk.crypto.cryptoki (PKCS#11 support) modules is appropriate for Cryptomator's encryption functionality. These are standard JDK security modules that enhance cryptographic capabilities.

---

28-31: Verification of OpenJFX 25 checksums cannot be completed automatically.

The sandbox environment lacks tools and network access to download and verify the OpenJFX 25 binaries. The latest version is currently 25.0.1, confirming that OpenJFX 25 exists, but the actual checksums cannot be validated against downloaded files.

To proceed, manually verify the checksums by:

• Downloading the binaries from Gluon's official distribution
• Computing sha256 hashes and comparing against the PKGBUILD values
• Or consulting Gluon's release documentation or GitHub repositories for published checksums

---

36-99: ****

This is an AUR (Arch User Repository) packaging repository containing only a PKGBUILD file. The PKGBUILD itself constitutes the build instructions for this package, and it has already been updated with the necessary changes for the 1.18.0 release, including new jlink modules (jdk.crypto.ec, jdk.crypto.cryptoki) and updated jpackage configuration. No separate documentation files exist in this repository that require updating.

Likely an incorrect or invalid review comment.

.SRCINFO (2)

19-19: OpenJFX 25 update verified.

OpenJFX 25 requires JDK 23 or later, so it is compatible with JDK 24.0.1. The OpenJFX 25 binaries are available for both x86_64 and aarch64 architectures. The update is safe to proceed.

---

24-24: Manually verify the sha256sum for the 1.18.0 source tarball.

GitHub does not publish official checksums for auto-generated source archives. Download the tarball and verify the checksum matches 7102e5a6fdd196b4c0e7a479aa8c17fbee7822238b04960651d95cea40cf5646:

curl -sL https://github.com/cryptomator/cryptomator/archive/refs/tags/1.18.0.tar.gz | sha256sum