Skip to content

Conversation

@iammajid
Copy link
Contributor

No description provided.

@iammajid iammajid self-assigned this Feb 14, 2025
Copy link
Member

@tobihagemann tobihagemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert all changes that affect subpages of /hub/* like /hub/billing/. They shouldn't change. Only /hub/ itself should be changed to /for-teams/.

@iammajid iammajid force-pushed the feature/add-subpage-for-individuals branch from 69c2e84 to 9446193 Compare February 14, 2025 16:04
@tobihagemann tobihagemann marked this pull request as ready for review February 19, 2025 11:04
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 19, 2025

Walkthrough

This pull request implements a series of modifications across several aspects of the project. In the CSS assets, the utility classes .min-vh-66 and .min-vh-80 have been removed and replaced by more explicit Tailwind CSS classes (min-h-[66vh] and min-h-[80vh]). Multiple new content files for individual users and team pages (in both German and English) have been added, while legacy hub pages have been deleted. FAQ and pricing entries in YAML files have been updated or introduced to provide detailed information on Cryptomator. Additionally, navigation links in the configuration file have been revised to reflect new paths, and the internationalization files for both German and English have been extended with additional entries to improve clarity. Changes to various HTML templates streamline layout configurations, update responsive behaviors, and adjust script loading for newsletters.

Suggested reviewers

  • CuriousPurah

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (5)
layouts/for-individuals/single.html (1)

16-16: Review CTA Link Destination.
The primary CTA button in the header currently links to {{ .Site.LanguagePrefix }}/downloads/. Verify if this is intentional or if it should instead direct users to a page tailored for individual users (for example, /for-individuals/).

i18n/en.yaml (2)

231-247: Metrics & Expertise Details
The display metrics (e.g. “3M+” for downloads and “10 Years” for expertise) are concise and eye‑catching. Please ensure these figures are backed by real data or are expected to remain static over time.


267-295: Features Section
The features are well articulated. One minor suggestion: in for_individuals_open_source_description, the word “Commitment” might be enhanced with a more descriptive phrasing (e.g. “Dedication to Open Source”) if that better fits your messaging.

i18n/de.yaml (2)

231-247: Zahlenwerte & Expertise-Angaben
The metrics (e.g. “3M+” and “10 Jahre”) and their accompanying descriptions (“Downloads” and “Erfahrung”) are succinct and clear. As with the English version, it may be wise to ensure these numbers are up‑to‑date with current statistics.


267-295: Features-Bereich
The features descriptions are comprehensive. One small nitpick: in for_individuals_open_source_description, “Engagement” is used to express a commitment to open source. Consider if an alternative like “Bekenntnis zu Open Source” might capture the intended sentiment even more strongly.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2a3e358 and 51f9fe3.

⛔ Files ignored due to path filters (3)
  • static/img/for-individuals/screenshot-1.png is excluded by !**/*.png
  • static/img/for-individuals/screenshot-2.png is excluded by !**/*.png
  • static/img/for-individuals/screenshot-3.png is excluded by !**/*.png
📒 Files selected for processing (20)
  • assets/css/custom.css (0 hunks)
  • content/for-individuals.de.html (1 hunks)
  • content/for-individuals.en.html (1 hunks)
  • content/for-teams.de.html (1 hunks)
  • content/for-teams.en.html (1 hunks)
  • content/hub.de.html (0 hunks)
  • content/hub.en.html (0 hunks)
  • data/de/for_individuals_faq.yaml (1 hunks)
  • data/de/pricing_individuals_faq.yaml (1 hunks)
  • data/en/for_individuals_faq.yaml (1 hunks)
  • data/nav.yaml (1 hunks)
  • i18n/de.yaml (1 hunks)
  • i18n/en.yaml (1 hunks)
  • layouts/_default/baseof.html (1 hunks)
  • layouts/downloads/list.html (1 hunks)
  • layouts/downloads/single.html (1 hunks)
  • layouts/for-individuals/single.html (1 hunks)
  • layouts/for-teams/single.html (1 hunks)
  • layouts/index.html (4 hunks)
  • layouts/partials/nav.html (1 hunks)
💤 Files with no reviewable changes (3)
  • assets/css/custom.css
  • content/hub.en.html
  • content/hub.de.html
✅ Files skipped from review due to trivial changes (5)
  • layouts/downloads/single.html
  • content/for-individuals.de.html
  • content/for-teams.de.html
  • content/for-teams.en.html
  • content/for-individuals.en.html
🔇 Additional comments (25)
data/nav.yaml (1)

2-2: Navigation Links Update: Confirmed Updated ProductsRelLinks.
The new ProductsRelLinks now references the subpages for individuals and teams, and includes /downloads. Please verify that this ordering and inclusion meets the intended navigation UX.

data/de/pricing_individuals_faq.yaml (1)

2-2: Clarify Android Availability in FAQ Answer.
The answer now explicitly mentions that Cryptomator is free on Windows, macOS, Linux, and iOS, but “(noch) nicht” on Android—with the free iOS version available only in read-only mode. This added nuance improves clarity about platform availability.

layouts/downloads/list.html (1)

7-7: Tailwind CSS Class Modification.
The CSS class has been updated from a generic utility (e.g. .min-vh-66) to an explicit Tailwind CSS class min-h-[66vh], which sets the minimum height more clearly. Ensure that the rendered layout meets the design specifications on various devices.

data/en/for_individuals_faq.yaml (1)

1-43: Comprehensive English FAQ for Individuals Added.
This new file provides an extensive set of FAQ entries covering Cryptomator’s usage, security, installation process, and more. The questions and answers are clear and well-structured. Please double-check that all hyperlink references (e.g., to open-source documentation) are correct and that the tone aligns with overall product messaging.

data/de/for_individuals_faq.yaml (1)

1-43: Comprehensive German FAQ for Individuals Added.
The newly added FAQ entries in German cover key topics regarding Cryptomator—from functionality and security to installation and cloud compatibility. Ensure that all localized URLs (such as links to /de/encrypt-dropbox/ and /de/for-teams/) are accurate and that the language nuances correctly reflect the intended messaging.

layouts/_default/baseof.html (1)

76-76: Tailwind CSS Class Update for Section Container.
The replacement of min-vh-80 with min-h-[80vh] is correct and aligns with the new Tailwind CSS approach. Please verify that this change is applied consistently across the project.

layouts/for-teams/single.html (2)

2-2: Updated Minimum Height Class.
The change from the old utility (min-vh-66) to min-h-[66vh] ensures consistency with the new Tailwind conventions.


7-7: Responsive Width Adjustment.
The container width is now set as w-full md:w-2/3 lg:w-3/5, which provides more refined responsiveness. Please double-check that these proportions match the intended design for team pages.

layouts/partials/nav.html (1)

17-17: Navigation Visibility Logic Updated.
The condition for displaying the "CRYPTOMATOR" span now includes checks for /for-individuals and /for-teams (in addition to /downloads). This update ensures that the navigation text is hidden appropriately on these new sections.

layouts/for-individuals/single.html (5)

1-22: New "For Individuals" Homepage Header.
The hero section is well structured with a clear header, image, and supporting text. Note that the section uses a breakpoint-specific class (md:min-h-[66vh]), differing from the non-breakpoint version used in similar templates (e.g. in the teams page). Please confirm that the header’s minimum height should only apply at medium (and above) screen sizes.


23-46: Features Grid Section.
The grid showcasing key benefits (downloads, expertise, open source, users worldwide) is clear, accessible, and visually consistent.


48-77: Workflow Steps Clarity.
Your workflow sections—each combining an image with corresponding text—are organized well using flexbox and lazy loading. Ensure all alt texts are descriptive and that the image paths are accurate.


80-141: Features, FAQ, and Community Sections.
The later sections (detailed features, FAQ handled via Alpine.js, and community engagement) are implemented cleanly and follow a consistent structure. The FAQ iteration using a dynamic array is efficient.


172-196: Newsletter Subscription and Social Links.
The newsletter form uses Alpine.js effectively to manage state and show error/success messages. Also, the social media link section is concise and functional. Just confirm that the listId value (6) is correct for the intended mailing list.

layouts/index.html (3)

13-13: Hero Section Min-Height Update.
The hero section now uses min-h-[66vh], which is consistent with other layout updates. The combination of background classes such as header-bg and bg-dark creates a strong visual impact.


22-24: Updated Call-To-Action Buttons.
The two new CTA buttons directing users to /for-individuals/ and /for-teams/ are clear and feature updated sizing (w-full md:w-64). This update aligns with the new navigation and content structure.


115-125: Newsletter and Testimonials Sections.
The newsletter, testimonial, and subsequent sections (such as sponsor and partner displays) seem to maintain their functionality and styling. These components appear well integrated with recent changes.

i18n/en.yaml (4)

219-230: Header & CTA for Individuals Section
The new header keys (e.g. for_individuals_header_title and for_individuals_header_cta) clearly articulate a strong value proposition for individual users. The marketing tone in “Keep your cloud data truly yours” is engaging.


248-266: Workflow Steps for Vault Creation
The workflow keys (steps “Create a Vault”, “Securely Store Files”, and “Sit Back and Relax”) are clear and guide users logically through the setup process. The language is concise and appropriate for the subpage's purpose.


296-302: Community Engagement Prompt
The invitation text for joining the community (“Couldn't find an answer?” and the CTA “Join Community”) is inviting and fits well with the overall tone.


304-314: Home Section Adjustments
The updates in the home section (e.g. home_header_for_individuals_cta and home_header_for_teams_cta) align nicely with the launch of the individuals subpage. Please double‑check that the call-to-action language remains consistent across the site.

i18n/de.yaml (4)

219-230: Header & CTA for Individuelle Nutzer
The new German keys for the header section (for example, for_individuals_header_title with “Deine Daten in der Cloud gehören dir allein”) effectively communicate the value proposition. Also, the alt text in for_individuals_header_woman_laptop_alt correctly mirrors the English version; just verify that “Cryptobot” is indeed the intended term here.


248-266: Ablaufschritte für Tresor-Erstellung
The workflow steps are well translated and easy to follow – “1. Tresor erstellen”, “2. Dateien sicher ablegen”, and “3. Entspannt zurücklehnen” provide a logical progression for users setting up their vaults.


296-302: Einladung zur Community
The call-to-action for community engagement (“Keine Antwort gefunden?” with CTA “Community beitreten”) is friendly and clear. It effectively encourages users to seek further interaction if they have questions.


303-314: Home Bereich – Lokalisierung
The Home section adjustments (e.g. home_header_for_individuals_cta as “Für Einzelnutzer” and home_header_for_teams_cta as “Für Teams”) are consistent with the new individuals subpage. The translations maintain the intended tone and overall consistency.

@tobihagemann tobihagemann merged commit 325a23a into develop Feb 19, 2025
4 checks passed
@tobihagemann tobihagemann deleted the feature/add-subpage-for-individuals branch February 19, 2025 11:10
@coderabbitai coderabbitai bot mentioned this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants