Skip to content

Feature: Desktop Release 1.19.3#175

Merged
infeo merged 2 commits into
mainfrom
feature/desktop-1.19.3
Jun 29, 2026
Merged

Feature: Desktop Release 1.19.3#175
infeo merged 2 commits into
mainfrom
feature/desktop-1.19.3

Conversation

@infeo

@infeo infeo commented Jun 29, 2026

Copy link
Copy Markdown
Member

Also fixes the CI workflow for automatic updates.

@infeo infeo self-assigned this Jun 29, 2026
@infeo infeo changed the base branch from develop to main June 29, 2026 13:05
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The pull request makes two changes: it corrects the workflow in .github/workflows/update-desktop.yml to set ASSETS_JSON from github.event.client_payload.release instead of github.event.client_payload.release.assets, adjusting the JSON shape consumed by jq filters. It also updates config/_default/params.yaml to replace all six desktop artifact entries (exe, msi, dmg, dmg-arm64, appimage, appimage-aarch64) from version 1.19.2 to 1.19.3, including updated filenames, download URLs, signature URLs, and checksums.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

Suggested labels

type:enhancement

Suggested reviewers

  • tobihagemann
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: updating the desktop release to 1.19.3.
Description check ✅ Passed The description is related to the changeset and mentions the CI workflow fix included here.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/desktop-1.19.3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/update-desktop.yml:
- Line 80: ASSETS_JSON is now populated with the full release object, but the jq
logic still expects an array of asset objects, so update the workflow to keep
ASSETS_JSON aligned with the selectors used later in the job. Fix the mismatch
by either setting ASSETS_JSON from github.event.client_payload.release.assets,
or changing the jq expressions that consume it to iterate over .assets[] instead
of assuming the top-level value is already an asset list.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 42ec83be-84e6-44e0-9cc6-700b6096cd9d

📥 Commits

Reviewing files that changed from the base of the PR and between 3813196 and 314ce87.

📒 Files selected for processing (2)
  • .github/workflows/update-desktop.yml
  • config/_default/params.yaml

Comment thread .github/workflows/update-desktop.yml
@infeo infeo merged commit c365b44 into main Jun 29, 2026
5 checks passed
@infeo infeo deleted the feature/desktop-1.19.3 branch June 29, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant