Skip to content

Comments

Update Screenshots And Remove Step 3 Account Setup#113

Merged
mindmonk merged 3 commits intodevelopfrom
update-desktop-screenshots-in-hub-subpages
Jan 28, 2026
Merged

Update Screenshots And Remove Step 3 Account Setup#113
mindmonk merged 3 commits intodevelopfrom
update-desktop-screenshots-in-hub-subpages

Conversation

@mindmonk
Copy link
Contributor

@mindmonk mindmonk commented Jan 26, 2026

Fix: #110

@mindmonk mindmonk requested a review from infeo January 26, 2026 13:57
@coderabbitai
Copy link

coderabbitai bot commented Jan 26, 2026

Walkthrough

This documentation update modifies the vault access flow in docs/hub/access-vault.md. The Account Setup subsection has been removed entirely, causing subsequent sections to be renumbered. New content describing device registration steps (including name entry and Account Key input) and an access-denied scenario has been added under the Register Device section. The narrative has been adjusted to reflect that the vault unlocks after registration and permission approval.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested reviewers

  • overheadhunter
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess whether it relates to the changeset. Consider adding a pull request description explaining the motivation and context for removing the Account Setup step and updating screenshots.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main changes: updating screenshots and removing the Account Setup step from the documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
docs/hub/access-vault.md (1)

58-58: The referenced image files do not exist in the repository.

The markdown references /img/hub/unlock-successfull-desktop.png and /img/hub/unlock-successfull-hub.png (line 58 and 62), but these files are not present in static/img/hub/. This will cause broken image links in the documentation. Determine the correct image filenames, or add the missing image files and update the references accordingly.

🤖 Fix all issues with AI agents
In `@docs/hub/access-vault.md`:
- Line 34: Replace the incorrect phrase "did setup your account" in the sentence
starting "If you just did setup your account, a vault owner needs to grant you
access..." with a correct form such as "have just set up your account" (or
simply "just set up your account") so the sentence reads: "If you have just set
up your account, a vault owner needs to grant you access for the requested vault
as described [here](vault-management.md#update-permissions). Retry unlocking the
vault after the vault owner granted you access." Ensure only the phrasing is
changed and links/preceding/following punctuation remain intact.
- Line 50: The sentence "After that, you will see a confirmation dialog, unlock
the vault again." is a comma splice; split into two sentences or use a
conjunction/semicolon. Replace it with e.g. "After that, you will see a
confirmation dialog. Then unlock the vault again." and commit the change where
that sentence appears.
♻️ Duplicate comments (1)
docs/hub/access-vault.md (1)

62-62: Verify image filename spelling.

Same issue as line 58: "successfull" should be "successful". Please verify and correct the image filename reference.

🧹 Nitpick comments (1)
docs/hub/access-vault.md (1)

34-50: Clarify the relationship between access denial and device registration scenarios.

The section presents two distinct scenarios (access denial and device registration) but doesn't clearly explain when each occurs or how they relate to each other. A user might wonder: Does device registration happen before or after access is granted? Can both scenarios occur in sequence?

Consider restructuring to make the flow clearer, such as:

  • Using subheadings like "3.1 If Access is Denied" and "3.2 Register Your Device"
  • Explicitly stating the conditions under which each scenario occurs
  • Clarifying whether device registration is required for first-time users who already have permissions

Copy link
Member

@infeo infeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The term "fritz.box" must be removed from the screenshot. The docs must not advertise any vendor/product if not necessary.

@mindmonk mindmonk requested a review from infeo January 28, 2026 09:25
@mindmonk mindmonk merged commit 5bf0b43 into develop Jan 28, 2026
2 checks passed
@infeo infeo deleted the update-desktop-screenshots-in-hub-subpages branch February 23, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Screenshots on 'Working with Vaults' and 'Vault Recovery'

2 participants