Skip to content

Feature: Admin Config#128

Merged
infeo merged 3 commits intodevelopfrom
feature/admin-config
Mar 8, 2026
Merged

Feature: Admin Config#128
infeo merged 3 commits intodevelopfrom
feature/admin-config

Conversation

@infeo
Copy link
Member

@infeo infeo commented Mar 8, 2026

Replaces the advanced settings with the new admin config ( cryptomator/cryptomator#4105).

The advanced settings were disabled in cryptomator/cryptomator#4132.

@infeo infeo self-assigned this Mar 8, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 8, 2026

Warning

Rate limit exceeded

@infeo has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 16 minutes and 42 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4064978c-ecc6-4242-8f9b-d7015a2c105c

📥 Commits

Reviewing files that changed from the base of the PR and between 8506545 and 2dca392.

📒 Files selected for processing (1)
  • docs/desktop/network.md

Walkthrough

This pull request adds a new documentation page docs/desktop/admin-config.md describing a system-level, persistent admin configuration file (locations per OS, UTF-8 key-value format, escaping rules, substitutions, and a table of configurable properties including cryptomator.logDir, cryptomator.pluginDir, cryptomator.p12Path, cryptomator.mountPointsDir, cryptomator.disableUpdateCheck). It also removes docs/desktop/advanced-settings.md (the previous Advanced Setting Properties documentation).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Feature: Admin Config' directly corresponds to the main change: adding new admin configuration documentation while removing advanced settings documentation.
Description check ✅ Passed The description is directly related to the changeset, explaining that advanced settings are being replaced with the new admin config and referencing relevant upstream PRs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/admin-config

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docs/desktop/admin-config.md`:
- Around line 39-41: The fenced code block containing the properties line
"cryptomator.pluginDir=@{userhome}/cryptomator/plugins" lacks a language tag
(tripping MD040) — add the language identifier "properties" after the opening
backticks of that fenced block so it becomes ```properties to enable proper
linting and syntax highlighting.
- Around line 9-10: Replace the first sentence with a tighter, clearer phrasing:
change "The admin configuration allows device or system administrators to
configure environment properties for Cryptomator to ensure for all device users
Cryptomator runs in the desired context." to something shorter like "The admin
configuration lets device or system administrators set environment properties
for Cryptomator, ensuring it runs in the desired context for all device users."
Keep the following sentence about it being a retained key-value file as-is.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5e116c55-0e7b-4049-ae5c-8a2c20913f50

📥 Commits

Reviewing files that changed from the base of the PR and between 02a1d06 and 971b081.

📒 Files selected for processing (2)
  • docs/desktop/admin-config.md
  • docs/desktop/advanced-settings.md
💤 Files with no reviewable changes (1)
  • docs/desktop/advanced-settings.md

infeo and others added 2 commits March 8, 2026 19:26
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@infeo infeo merged commit 2fd2db7 into develop Mar 8, 2026
2 checks passed
@infeo infeo linked an issue Mar 8, 2026 that may be closed by this pull request
@infeo infeo deleted the feature/admin-config branch March 8, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace user-defined-config page with info about admin config

1 participant