add new "hub trusted hosts" properties

[overheadhunter]

No description provided.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5e01e0d7-6660-439c-8a5c-30ef16662ffb

📥 Commits

Reviewing files that changed from the base of the PR and between 4a405e9 and 7f39874.

📒 Files selected for processing (1)

• docs/desktop/admin-config.md

🚧 Files skipped from review as they are similar to previous changes (1)

• docs/desktop/admin-config.md

---

Walkthrough

This change updates docs/desktop/admin-config.md to add two admin configuration keys: cryptomator.hub.allowedHosts (comma-separated list of Hub host URLs allowed for Hub unlock) and cryptomator.hub.enableTrustOnFirstUse (boolean controlling whether unknown Hub hosts prompt the user or are disallowed; defaults to true). The change is documentation-only.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No pull request description was provided by the author, so this check cannot evaluate meaningful content related to the changeset.	Add a description explaining the purpose and context of these new configuration properties for better documentation and reviewer understanding.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: adding new hub trusted hosts properties to the configuration documentation.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feature/hub-tofu

📝 Coding Plan for PR comments

• Generate coding plan

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docs/desktop/admin-config.md`:
- Around line 60-61: Clarify that cryptomator.hub.allowedHosts accepts a
comma-separated list of hostnames (no scheme or path), e.g. hub1.example.com,
hub2.example.com, and update the example to match that format; explicitly state
that entries are matched by hostname (optionally with port) and that TLS
scheme/paths are ignored. Also document the interaction with
cryptomator.hub.enableTrustOnFirstUse: when enabled (true) hosts not listed in
cryptomator.hub.allowedHosts are treated as "unknown" and will trigger a
Trust-On-First-Use prompt, whereas when disabled (false) connections to hosts
not in allowedHosts are rejected. Ensure references to
cryptomator.hub.allowedHosts and cryptomator.hub.enableTrustOnFirstUse appear
together in the description for clarity.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f348d0cc-cb05-4899-9d5f-d8a2b37e81b3

📥 Commits

Reviewing files that changed from the base of the PR and between e190e19 and 166230c.

📒 Files selected for processing (1)

• docs/desktop/admin-config.md

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

docs/desktop/admin-config.md (1)

60-60: Consider minor wording refinements.

For consistency with standard English conventions:

• "comma separated" → "comma-separated" (compound adjective before noun)
• "host url" → "host URL" (URL is typically capitalized as an acronym)

📝 Suggested refinements

-| `cryptomator.hub.allowedHosts=[UrlList]` | List of hosts that Cryptomator is allowed to connect to during Hub unlock. List entries are comma separated and each host url consists of `scheme:host:port` (`port` is optional). For example `https://hub1.example.com,https://hub2.example.com:4432` |
+| `cryptomator.hub.allowedHosts=[UrlList]` | List of hosts that Cryptomator is allowed to connect to during Hub unlock. List entries are comma-separated and each host URL consists of `scheme:host:port` (`port` is optional). For example `https://hub1.example.com,https://hub2.example.com:4432` |

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@docs/desktop/admin-config.md` at line 60, Edit the description of
cryptomator.hub.allowedHosts=[UrlList] to apply the suggested wording
refinements: change "comma separated" to "comma-separated" and "host url" to
"host URL" so the sentence reads e.g. "List entries are comma-separated and each
host URL consists of `scheme:host:port` (`port` is optional)." Keep the example
unchanged.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docs/desktop/admin-config.md`:
- Line 61: Remove the comma after "unknown", change "wellknown" to "well-known",
and rephrase the definition to remove ambiguity: state that "A Hub host is
unknown if it meets none of the following:" and then list the three conditions
using the exact config/key names (e.g. "is well-known (*.cryptomator.cloud)",
"is listed in cryptomator.hub.allowedHosts", "has been allowed by the user") so
it's clear that a host is unknown only when none of those conditions hold for
the host.

---

Nitpick comments:
In `@docs/desktop/admin-config.md`:
- Line 60: Edit the description of cryptomator.hub.allowedHosts=[UrlList] to
apply the suggested wording refinements: change "comma separated" to
"comma-separated" and "host url" to "host URL" so the sentence reads e.g. "List
entries are comma-separated and each host URL consists of `scheme:host:port`
(`port` is optional)." Keep the example unchanged.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 87873ebf-ac05-4fa6-a21f-6a7af7b84d9e

📥 Commits

Reviewing files that changed from the base of the PR and between 166230c and 4a405e9.

📒 Files selected for processing (1)

• docs/desktop/admin-config.md