Skip to content

Feature: Build site on PRs#157

Merged
infeo merged 3 commits into
developfrom
feature/build-prs
May 11, 2026
Merged

Feature: Build site on PRs#157
infeo merged 3 commits into
developfrom
feature/build-prs

Conversation

@infeo
Copy link
Copy Markdown
Member

@infeo infeo commented May 11, 2026

This PR enables building the site for pull requests.

The site is not deployed, but a built can already show issues.

and allow it for pull requests
@infeo infeo self-assigned this May 11, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 11, 2026

Review Change Stack

Warning

Rate limit exceeded

@infeo has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 49 minutes and 55 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3a14c497-6cf2-40cd-a19a-a29b84910a2e

📥 Commits

Reviewing files that changed from the base of the PR and between aaf04c1 and 2068d10.

📒 Files selected for processing (1)
  • .github/workflows/build.yml

Walkthrough

This pull request refactors the GitHub Actions CI/CD pipeline by extracting build logic into a reusable workflow. A new build.yml workflow provides an optional site-url input (defaulting to production docs URL) and outputs an artifact ID. The existing deploy.yml workflow is updated to call this reusable build workflow instead of duplicating inline build steps, passing the appropriate site URL based on the target branch. Both production and staging deployment jobs now download artifacts using the shared artifact ID output and handle them with environment-specific configurations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • cryptomator/docs#69: Both PRs modify the GitHub Actions deploy workflow (.github/workflows/deploy.yml), changing how site build and artifact handling work.
  • cryptomator/docs#68: Both PRs modify GitHub Actions workflows for building and deploying the site, including artifact handling and deployment job configuration.

Suggested reviewers

  • overheadhunter
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Feature: Build site on PRs' directly matches the main objective of the PR, which is to enable building the site for pull requests.
Description check ✅ Passed The description clearly relates to the changeset by explaining that the PR enables building the site for pull requests without deployment, matching the workflow modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/build-prs

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/build.yml:
- Around line 16-17: The SITE_URL env default currently uses inputs.site-url
which is empty for pull_request builds; update the workflow so SITE_URL picks
the target-branch URL when inputs.site-url is not provided by inspecting the PR
base branch (use github.event.pull_request.base.ref) and map that to the staging
URL for the develop target and to the production URL otherwise; specifically
adjust the env SITE_URL assignment in .github/workflows/build.yml to fall back
from inputs.site-url to a conditional based on
github.event.pull_request.base.ref so PRs targeting develop get the staging URL
and all others get the production URL.
- Around line 23-24: The outputs mapping uses the wrong output key
(steps.upload.outputs.artifact_id); change it to use the hyphenated key by
setting the outputs entry named artifact-id to the value from
steps.upload.outputs['artifact-id'] (i.e., replace the current artifact_id
expression with ${{ steps.upload.outputs['artifact-id'] }}), so the reusable
workflow exposes the correct artifact-id output.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: acf938f6-38f7-4448-8339-7605a7e97e19

📥 Commits

Reviewing files that changed from the base of the PR and between 25cfea0 and aaf04c1.

📒 Files selected for processing (2)
  • .github/workflows/build.yml
  • .github/workflows/deploy.yml

Comment thread .github/workflows/build.yml Outdated
Comment thread .github/workflows/build.yml Outdated
@infeo infeo merged commit 7e2289b into develop May 11, 2026
3 checks passed
@infeo infeo deleted the feature/build-prs branch May 11, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant