Migrated Entities + DAOs → Panache#2
Merged
overheadhunter merged 7 commits intodevelopfrom Oct 15, 2021
Merged
Conversation
Comment on lines
-125
to
+75
| ", access=" + access.stream().map(Access::getId).collect(Collectors.toList()) + | ||
| ", access=" + access.stream().map(a -> a.id).collect(Collectors.toList()) + |
Member
There was a problem hiding this comment.
I know this was the same before, but
- why convert a set to a list?
- why not just use
new ArrayList(access)
Member
Author
There was a problem hiding this comment.
Apparently only the id should be displayed. By using the arrayList, we would still need a projection onto the id only.
overheadhunter
requested changes
Oct 15, 2021
overheadhunter
approved these changes
Oct 15, 2021
overheadhunter
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the Panache the Quarkus Stack offers a library to reduce Persistence boiler plate code.
This PR uses the lib and its Active Record pattern to remove all standard getter and setter methods as well as remove Daos for the existing entities. Although there are more features, this is a good first step to die into the framework.
Active Record was chosen over Repository Pattern due to the context: Scalability is not a point currently, but a clean coded solution.
Additionally, on request, the package name for the entities was changed.