-
-
Notifications
You must be signed in to change notification settings - Fork 15
Feature: Add "Browser Language" Option to Language Selection #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe pull request introduces changes to the language selection functionality in the Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (8)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this initial state, the application defaults to the browser's language for localization.
This is not true, if the user doesn't have a language selected, English is currently used as default so not set corresponds to English.
Edit: No idea what went wrong with the test, on Friday it didn't work on my device, today it uses the language of the browser, which is pretty weird.
Currently, when selecting a language in the user profile, no selection is shown until the user explicitly picks one. In this initial state, the application defaults to the browser's language for localization. Once a language is selected, there is no way to revert to the previous behavior.
With this PR, a new option titled "Browser Language" is added to the language selection list. This ensures that:
Changes