Add support for regionalized locales and add further langs #350

SailReal · 2025-07-31T13:08:37Z

When we use the full locale, i18n does the fallback from e.g. de-DE-bavarian --> de-DE --> de, see https://vue-i18n.intlify.dev/guide/essentials/fallback#implicit-fallback-using-locales

This also required to migrate the stored ISO 639‑1 two letter codes to the new full locales.

Also added Latvian, Portuguese (Brazil), Russian, Ukrainian, Chinese (Taiwan)

I also removed https://cryptomator.org/${languagePathComponent}hub/billing/* because imo this is getting to complicated and error prone with regionalized locales in comparison to the benefit we get from it.

When we use the full locale, i18n does the fallback from e.g. de-DE-bavarian --> de-DE --> de, see https://vue-i18n.intlify.dev/guide/essentials/fallback#implicit-fallback-using-locales This also required to migrate the stored ISO 639‑1 two letter codes to the new full locales. Also added Latvian, Portuguese (Brazil), Russian, Ukrainian, Chinese (Taiwan)

coderabbitai · 2025-07-31T13:11:12Z

Walkthrough

This change set updates the localization and internationalization infrastructure across the project. In the backend, a database migration modifies the "user_details" table to use region-specific locale codes (e.g., 'en-US') instead of generic two-letter codes. The frontend's i18n setup is refactored to use these full locale identifiers, with new translations added for Latvian, Brazilian Portuguese, Russian, Ukrainian, and Traditional Chinese (Taiwan). The changelog is updated to reflect these additions. Additionally, logic in the admin settings component is simplified by removing locale-based URL construction for subscription management.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~15–20 minutes

Possibly related PRs

Preserve User Language Setting #313: Adds backend support for storing and preserving the user's language setting and integrates it into the API and frontend user profile, complementing the frontend i18n changes in this PR.

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5044a12 and c14894b.

📒 Files selected for processing (1)

frontend/src/i18n/index.ts (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

frontend/src/i18n/index.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Run Tests

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feature/support-regionalized-locales

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

overheadhunter

I don't understand the fallback mechanism yet. How does pt-BR know what resources to load when falling back to pt?

frontend/src/i18n/index.ts

SailReal · 2025-07-31T14:22:15Z

I don't understand the fallback mechanism yet. How does pt-BR know what resources to load when falling back to pt?

The magic is in the "fallback chain algorithm" defined in https://github.com/intlify/vue-i18n/blob/master/packages/core-base/src/fallbacker.ts together with https://github.com/intlify/vue-i18n/blob/master/packages/core-base/src/translate.ts

If I understand the code correctly, if we have no pt and no pt-BR but

messages = {
  'pt-PT': { hello: 'foo' },
  'en-US': { hello: 'bar' }
}

in fallbackWithLocaleChain we would have

block = ['pt-BR']

tokens = ['pt','BR']
target = 'pt-BR' → push to chain
tokens = ['pt']
target = 'pt' → push to chain
tokens = [] → stop

block = ['en-US'] → append to chain

As we also have e.g. pt-PT as available messages, pt-PT is also added to the local chain as it reduces the tag and ensures all matching variants are added before hitting the final fallback which gives us the resulting chain ['pt-BR', 'pt', 'pt-PT', 'en-US'].

in https://github.com/intlify/vue-i18n/blob/master/packages/core-base/src/translate.ts#L818-L930 we iterate over each locale and do

pt-BR: messages['pt-BR'] undefined → skip.
pt: messages['pt'] undefined → skip.
pt-PT: messages['pt-PT'] exists → resolveValue(message, 'hello') = 'foo' → found → break.

SailReal requested a review from overheadhunter July 31, 2025 13:08

overheadhunter reviewed Jul 31, 2025

View reviewed changes

frontend/src/i18n/index.ts Outdated Show resolved Hide resolved

Apply suggestions from code review

c14894b

overheadhunter approved these changes Jul 31, 2025

View reviewed changes

SailReal merged commit 324cfa7 into develop Jul 31, 2025
8 checks passed

SailReal deleted the feature/support-regionalized-locales branch July 31, 2025 14:36

SailReal added this to the 1.4.4 milestone Aug 5, 2025

coderabbitai bot mentioned this pull request Dec 5, 2025

Feature: Improve browser locale detection and unify language selection behavior #371

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Add support for regionalized locales and add further langs #350

Add support for regionalized locales and add further langs #350

Uh oh!

SailReal commented Jul 31, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jul 31, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

overheadhunter left a comment

Uh oh!

Uh oh!

SailReal commented Jul 31, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Add support for regionalized locales and add further langs #350

Add support for regionalized locales and add further langs #350

Uh oh!

Conversation

SailReal commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Possibly related PRs

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

overheadhunter left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SailReal commented Jul 31, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

SailReal commented Jul 31, 2025 •

edited

Loading

coderabbitai bot commented Jul 31, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)