Merged
Conversation
* read keycloak config from configuration
# Conflicts: # spi/src/main/java/org/cryptomator/hub/entities/User.java # spi/src/main/java/org/cryptomator/hub/spi/UsersResource.java
infeo
reviewed
Oct 28, 2021
Member
infeo
left a comment
infeo
left a comment
There was a problem hiding this comment.
Unfortunately i cannot say a lot about the typescript part, but i tested it in a run and it works.
| @@ -1,4 +1,51 @@ | |||
| <template> | |||
| <!-- Notification for successfully creation of a realm --> | |||
Member
There was a problem hiding this comment.
Why not remove directly and just reference the git commit where the old state can be taken from?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The frontend is now capable to read app configuration from the
/setupresource.Doing so, it detects whether setup is required and redirects to a wizard. Currently it only contains Keycloak-related stuff, but may be extended later.
By configuring Keycloak dynamically, we no longer rely on assumptions hard-coded in realm configuration files, which allows to remove them and switch to Quarkus Dev Services for Keycloak provisioning during development.