Skip to content

Disable username field in admin user edit mode#422

Merged
iammajid merged 1 commit intodevelopfrom
fix/admin-disable-username-edit
Mar 17, 2026
Merged

Disable username field in admin user edit mode#422
iammajid merged 1 commit intodevelopfrom
fix/admin-disable-username-edit

Conversation

@iammajid
Copy link
Copy Markdown
Contributor

  • Disable the username input field when editing an existing user in admin panel
  • Exclude disabled username field from unsaved changes detection

@iammajid iammajid requested review from SailReal and overheadhunter and removed request for overheadhunter March 16, 2026 10:04
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b291427c-802d-41af-8e19-1e493c51bc1f

📥 Commits

Reviewing files that changed from the base of the PR and between af332f0 and e9e5fc4.

📒 Files selected for processing (1)
  • frontend/src/components/authority/UserEditCreate.vue

Walkthrough

The UserEditCreate.vue component is modified to disable the username input field when in EDIT mode by binding a disabled attribute to the mode prop condition. The unsaved changes detection logic is updated to exclude the username field from comparison when in EDIT mode, effectively making it read-only during edit operations while preserving change tracking for other fields.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • overheadhunter
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: disabling the username field in edit mode for admin user management.
Description check ✅ Passed The description clearly explains both aspects of the change: disabling the username field and excluding it from unsaved changes detection.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/admin-disable-username-edit
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can customize the high-level summary generated by CodeRabbit.

Configure the reviews.high_level_summary_instructions setting to provide custom instructions for generating the high-level summary.

@iammajid iammajid merged commit 293b03f into develop Mar 17, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants