Skip to content

Conversation

@infeo
Copy link
Member

@infeo infeo commented Jan 26, 2026

This PR disables xattr tests for FUSE-T in the CI builds.

See #147.

Summary by CodeRabbit

  • Tests
    • Enhanced OS-specific test handling for Linux and macOS to ensure mirror setup behaves correctly across platforms.
    • Added environment detection for a specific FUSE library variant and used it to conditionally gate Extended Attributes tests (now disabled in CI when that variant is present).

✏️ Tip: You can customize this high-level summary in your review settings.

@infeo infeo self-assigned this Jan 26, 2026
@infeo infeo added this to the next milestone Jan 26, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 26, 2026

📝 Walkthrough

Walkthrough

Detects a libfuse-t dylib and CI environment and conditionally adjusts test setup and gating. Adds public static boolean isFuseTLibAndCIEnvironment() and uses it to apply a MAC mount flag (-ononamedattr), create mirror dirs on Linux/Mac, and disable extended-attributes tests on CI when appropriate.

Changes

Cohort / File(s) Summary
Test Configuration & Utilities
jfuse-tests/src/test/java/org/cryptomator/jfuse/tests/MirrorIT.java
Added public isFuseTLibAndCIEnvironment() method. Adjusted OS-specific mirror setup: Linux creates mirror dir and returns PosixMirrorFileSystem; Mac path now conditionally adds -ononamedattr when isFuseTLibAndCIEnvironment() is true, then creates mirror dir and returns PosixMirrorFileSystem.
Test Gating / Imports
jfuse-tests/src/test/java/org/cryptomator/jfuse/tests/MirrorIT.java
Replaced/updated imports: added DisabledIf, removed Set. Extended Extended Attributes test disabling to include DisabledIf that checks isFuseTLibAndCIEnvironment() (in addition to existing DisabledOnOs).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐇 I sniff the dylib in the night,

If CI hums, I set flags right,
Mac and Linux, mirrors made,
Tests skip gently where they're laid,
A rabbit's tweak — small, sure delight.

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: disabling extended attributes tests for fuse-t in CI environments.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@infeo infeo merged commit 83ebf68 into develop Jan 26, 2026
10 checks passed
@infeo infeo deleted the feature/no-xattr-fuset branch January 26, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant