Skip to content

Conversation

@infeo
Copy link
Member

@infeo infeo commented Jan 26, 2026

This PR updates the project release JDK version to 25.

Additionally,

  • builds are reproducible
  • adjusting the pom by defining for each dependency a property.

Summary by CodeRabbit

  • Chores
    • Upgraded Java runtime environment from version 24 to 25
    • Enhanced build workflow with ISO-8601 timestamp tracking to improve build reproducibility
    • Implemented centralized version management for all dependencies and build plugins
    • Simplified maintenance and consistency across platform-specific build configurations

✏️ Tip: You can customize this high-level summary in your review settings.

@infeo infeo added this to the next milestone Jan 26, 2026
@infeo infeo self-assigned this Jan 26, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 26, 2026

📝 Walkthrough

Walkthrough

The pull request centralizes version management across Maven configuration files by replacing hardcoded version numbers with property references. The Java runtime in the build workflow is bumped from 24 to 25, and a build timestamp step is introduced to enable reproducible builds.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/build.yml
Java runtime version bumped from 24 to 25; step renamed to include build timestamp computation with ISO-8601 format via project.build.outputTimestamp property
Platform-Specific POM Files
jfuse-linux-aarch64/pom.xml, jfuse-linux-amd64/pom.xml, jfuse-mac/pom.xml, jfuse-win/pom.xml
jextract-maven-plugin version changed from hardcoded 0.4.0 to parameterized ${jextract.version} property reference
Root POM Configuration
pom.xml
Introduces centralized property-based version management with new properties (jb-annotations.version, junit.version, mockito.version, mvn-*.version, central-publishing.version, jacoco.version, jextract.version, project.build.outputTimestamp, and java.version bumped to 25); replaces hardcoded version literals throughout dependencies and pluginManagement with corresponding property references

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Versions once scattered, now gathered with care,
Properties centralized everywhere!
From twenty-four springs to twenty-five's grace,
Timestamps and builds in their rightful place! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Jdk 25' is vague and generic, using an abbreviation without context about what changes are being made beyond a version bump. Consider a more descriptive title that captures the main objectives, such as 'Update JDK to version 25 and introduce centralized dependency version management' or 'Upgrade to JDK 25 and make builds reproducible'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@pom.xml`:
- Line 49: The pom property junit.version is set to a non-existent JUnit 6
value; update the junit.version property to a valid JUnit 5 release (for example
set junit.version to 5.13.0-M3 or a current stable 5.x release) and ensure any
dependencies using the junit.version property (e.g., junit-jupiter artifacts)
are compatible with JUnit 5; after updating the property, run mvn
dependency:resolve or a build to verify dependency resolution succeeds.
🧹 Nitpick comments (1)
pom.xml (1)

117-118: Inconsistent version declaration for maven-compiler-plugin.

The version is hardcoded as 3.14.1 while ${mvn-compiler.version} is defined with the same value on line 61. For consistency with the centralized version management pattern used for all other plugins, use the property reference.

♻️ Suggested fix
 				<plugin>
 					<groupId>org.apache.maven.plugins</groupId>
 					<artifactId>maven-compiler-plugin</artifactId>
-					<version>3.14.1</version>
+					<version>${mvn-compiler.version}</version>
 					<configuration>

@infeo infeo merged commit a07e76f into develop Jan 26, 2026
12 checks passed
@infeo infeo deleted the feature/jdk-25 branch January 26, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant