Conversation
ian-barnes
approved these changes
Feb 14, 2022
| >>= fun body -> | ||
| let projects = Cs_api_core.parse_list_projects_response ~body in | ||
| match CCList.Assoc.get ~eq:String.equal name projects with | ||
| | None -> Lwt_result.fail "Project not found" |
There was a problem hiding this comment.
It's a tiny point, but perhaps it would be more helpful to say "Project \"" ^ name ^ "\" not found" or something like that?
khadijafen9
approved these changes
Feb 15, 2022
A project name can now be given instead of a project ID. The new option is `--project-name`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A project name can now be given instead of a project ID. The new option is
--project-nameand is mutually exclusive with--project-id.Currently, since our API lacks a way to get a
Projectby name directly, the tool downloads the full list of project IDs and names to determine which one matches the user-provided name.