Add slot name option#25
Merged
sbq-clements merged 2 commits intomasterfrom Mar 21, 2023
Merged
Conversation
sbq-clements
force-pushed
the
add-slot-name
branch
11 times, most recently
from
9a545d9 to
64b06f8
Compare
sbq-clements
force-pushed
the
add-slot-name
branch
6 times, most recently
from
2f5e8fc to
6d01ad8
Compare
sbq-clements
force-pushed
the
add-slot-name
branch
from
6d01ad8 to
e90163f
Compare
dromaludaire
approved these changes
Mar 21, 2023
dromaludaire
left a comment
dromaludaire
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for your work!
Sorry I didn't review this earlier, I did not link my sbt github account to the Cryptosense org and totally missed that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes:
--slot-nameoption to the upload trace command to be able to choose the name of the (existing or not) slot the trace will be uploaded to.