Skip to content

Bundle libcurl for Windows#52

Merged
bertrand-sb merged 1 commit intomainfrom
win-bundle-libcurl
Aug 21, 2024
Merged

Bundle libcurl for Windows#52
bertrand-sb merged 1 commit intomainfrom
win-bundle-libcurl

Conversation

@bertrand-sb
Copy link
Copy Markdown
Contributor

Changes for the user:

Other comments:

  • The download script was adjusted to use curl when it's available instead of wget. The latter was problematic on Windows; I couldn't get it to work with a specific output file (with -O).
  • I applied shellcheck recommendations to the download script.

Changes for the user:

- The Windows release now ships with `libcurl-4.dll` (from
  https://curl.se/windows/).

Other comments:

- The download script was adjusted to use `curl` when it's available
  instead of `wget`. The latter was problematic on Windows; I couldn't
  get it to work with a specific output file (with `-O`).
- I applied shellcheck recommendations to the download script.
Copy link
Copy Markdown

@Ant1-Provot Ant1-Provot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent !!

@bertrand-sb bertrand-sb merged commit 3926d49 into main Aug 21, 2024
@bertrand-sb bertrand-sb deleted the win-bundle-libcurl branch August 21, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants