This repository was archived by the owner on Sep 17, 2024. It is now read-only.
Add ability to configure sudo binary #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This will definitely conflict with #22 |
Member
|
I'll also @Trivernis to this then so you two could work on making both of these work together! |
Trivernis
reviewed
Aug 30, 2022
Trivernis
reviewed
Aug 30, 2022
Trivernis
reviewed
Aug 30, 2022
Member
|
You can just ignore the async rewrite when merging. I can apply small stuff like this in the async version afterwards. |
Member
|
@mrshmllow you can fix potential conflicts and work on this if you want to. The async stuff is merged |
Member
|
@mrshmllow as @Trivernis said you're welcome to start solving the conflicts |
mrshmllow
force-pushed
the
sudobin
branch
2 times, most recently
from
d9d55de to
f3b5e02
Compare
Contributor
Author
|
I enjoy force pushing |
Trivernis
suggested changes
Sep 7, 2022
Trivernis
approved these changes
Sep 8, 2022
Contributor
Author
|
Worlds messiest PR but lets go |
Member
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to configure your prefered sudo binary in
config.toml