Skip to content

Add inner transaction fee and clear state transaction check issues to Algorand not-so-smart-contracts #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2023
Merged

Add inner transaction fee and clear state transaction check issues to Algorand not-so-smart-contracts #294

merged 2 commits into from
Jul 11, 2023

Conversation

@S3v3ru5
Copy link
Contributor

@S3v3ru5 S3v3ru5 commented May 3, 2023

This PR adds two new issues to not-so-smart-contracts/algorand:

  1. Inner Transaction Fee: Inner transaction should be set to zero.
  2. Clear State Transaction Check: Contract does not check OnComplete field of an Application Call.

We should probably add this note in CONTRIBUTING.md: "Add links to new pages in SUMMARY.md".

@S3v3ru5 S3v3ru5 requested a review from montyly as a code owner May 3, 2023 08:04
@montyly montyly merged commit 84eada3 into master Jul 11, 2023
@montyly montyly deleted the algorand-fee-clear branch July 11, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@montyly montyly Awaiting requested review from montyly

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@S3v3ru5 @montyly