Skip to content

fix: getAllInterfaceFields in remaining codegen sites + fneg type tracking #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cs01 merged 2 commits into from
Mar 8, 2026
Merged

fix: getAllInterfaceFields in remaining codegen sites + fneg type tracking #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75c6fb0
fix: use getAllInterfaceFields in remaining sites, for..of loops, tra…
cs01 Mar 8, 2026
4ff833f
revert: undo unsafe getAllInterfaceFields cast in class.ts and unary …
cs01 Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions src/codegen/expressions/access/chained-access.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,10 @@ export function handleNestedInterfaceField(
const keys: string[] = [];
const tsTypes: string[] = [];
const types: string[] = [];
if (nestedInterfaceDef.fields) {
for (let i = 0; i < nestedInterfaceDef.fields.length; i++) {
const f = nestedInterfaceDef.fields[i] as { name: string; type: string };
keys.push(stripOptional(f.name));
tsTypes.push(f.type);
types.push(tsTypeToLlvm(f.type));
}
for (const f of ctx.getAllInterfaceFields(nestedInterfaceDef)) {
keys.push(stripOptional(f.name));
tsTypes.push(f.type);
types.push(tsTypeToLlvm(f.type));
}
ctx.setJsonObjectMetadata(fieldItem, { keys, types, tsTypes, interfaceType: undefined });
}
Expand Down
14 changes: 4 additions & 10 deletions src/codegen/llvm-generator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,13 +696,10 @@ export class LLVMGenerator extends BaseGenerator implements IGeneratorContext {
const keys: string[] = [];
const types: string[] = [];
const tsTypes: string[] = [];
for (let i = 0; i < this.ast.interfaces.length; i++) {
const iface = this.ast.interfaces[i];
for (const iface of this.ast.interfaces) {
if (!iface) continue;
if (iface.name === cleanName) {
if (!iface.fields) continue;
for (let j = 0; j < iface.fields.length; j++) {
const field = iface.fields[j] as InterfaceField;
for (const field of this.getAllInterfaceFields(iface)) {
if (!field) continue;
let fieldName = field.name;
if (fieldName.endsWith("?")) {
Expand Down Expand Up @@ -805,13 +802,10 @@ export class LLVMGenerator extends BaseGenerator implements IGeneratorContext {
return null;
}
if (!this.ast || !this.ast.interfaces) return null;
for (let i = 0; i < this.ast.interfaces.length; i++) {
const iface = this.ast.interfaces[i];
for (const iface of this.ast.interfaces) {
if (!iface) continue;
if (iface.name === interfaceName) {
if (!iface.fields) continue;
for (let j = 0; j < iface.fields.length; j++) {
const f = iface.fields[j] as InterfaceField;
for (const f of this.getAllInterfaceFields(iface)) {
if (!f) continue;
let fName = f.name;
if (fName.endsWith("?")) {
Expand Down
Loading