Skip to content

fix: use getAllInterfaceFields for http handler return type#136

Merged
cs01 merged 1 commit intomainfrom
fix/llvmgen-interface-fields
Mar 9, 2026
Merged

fix: use getAllInterfaceFields for http handler return type#136
cs01 merged 1 commit intomainfrom
fix/llvmgen-interface-fields

Conversation

@cs01
Copy link
Owner

@cs01 cs01 commented Mar 9, 2026

Summary

  • Fixes direct .fields access on interface in HTTP server handler return type detection
  • llvm-generator.ts:2617 was using retIface.fields which only returns OWN fields, missing inherited fields from extends
  • Now uses getAllInterfaceFields(retIface) to correctly detect headers and bodyLen fields on interfaces that inherit from a parent
  • Without this fix, if an HTTP handler returns an interface that inherits headers/bodyLen from a parent interface, the server wouldn't generate the correct response handling code

Test plan

  • All 434 tests pass
  • Self-hosting verification passes (verify:quick)

🤖 Generated with Claude Code

@cs01 cs01 merged commit 998d51d into main Mar 9, 2026
12 checks passed
@cs01 cs01 deleted the fix/llvmgen-interface-fields branch March 9, 2026 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant