fix: propagate ?. optional chaining to method call nodes in native parser#144
Merged
fix: propagate ?. optional chaining to method call nodes in native parser#144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parser-native/transformer.ts) never propagated?.from member expressions toMethodCallNode.optional, causing the native compiler to skip null-check branching for allobj?.method()callsoptcallnull-check blocks caused IR divergence between JS and native compilers (956 out of 2036 functions differed), leading to self-hosting failureslocandoptionalfields to all MethodCallNode creation sites in the native parser for consistent struct layoutTest plan
classes/optional-method-call.tsverifies?.returns null when object is nullverify:quickpasses (Stage 0 + Stage 1 self-hosting)🤖 Generated with Claude Code