fix: resolve inline type assertions to matching interfaces#162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
as { name: string; type: string }, it now parses the inline fields and finds the matching declared interfaceaccessObjectPropertyWithNamedInterfacewith correct GEP indices instead of falling back to untyped member accessfindInterfaceForFields(fieldNames)to generator context and LLVMGeneratorThis is the root cause fix for the 294 corrupted type strings per native compiler build. Previously, inline multi-field type assertions caused the native compiler to use JSON-style field lookup (
csyyjson_obj_get) instead of direct struct access (GEP), reading garbage memory.Test plan
npm run build— cleannpm test— 437 tests passnpm run verify:quick— Stage 0 + Stage 1 self-hosting passes