fix: eliminate oob array access in function parameter counting#185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
while (arr[idx])to count function parameters, which accesses index 0 of an empty array when a function has no parameters. In JavaScript this silently returnsundefined, but with runtime bounds checking enabled this becomes a crash..lengthcheck — simpler and correct for all cases.What this means for users
Previously, enabling full bounds checking (for string/object arrays) would cause the compiler itself to crash when compiling any code containing parameterless functions. This fix eliminates one of the compiler's own out-of-bounds array accesses, bringing us closer to enabling bounds checking across all array types.
Test plan
🤖 Generated with Claude Code