fix: improve error messages for set, map, constructor, and control flow errors#186
Merged
fix: improve error messages for set, map, constructor, and control flow errors#186
Conversation
…and member access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
throw new Error()calls toemitError()across Set, Map, Literals, control flow, and member access codegenerror: file.ts:5:3 — Set.add() requires exactly 1 argumentinstead of a raw JavaScript stack traceWhat this means for users
When you make a mistake like calling
mySet.add()without arguments,new Set()without a type parameter, or usingbreakoutside a loop, you'll now get a clear error message pointing to the exact file and line — instead of an intimidating stack trace that looks like the compiler crashed.Affected errors
Set.add/has/delete()argument countMap.set/get/has/delete()argument countnew Set()missing type argumentnew RegExp/Uint8Array/URL()missing argumentsthiskeyword outside class contextbreak/continueoutside loopTest plan
🤖 Generated with Claude Code