fix: emit compile error for for...of on numeric maps instead of segfaulting#200
Merged
fix: emit compile error for for...of on numeric maps instead of segfaulting#200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
for (const [k, v] of numericMap)on aMap<number, number>silently generated wrong code — it calledstringMapGen.generateStringMapEntrieson a%Mapstruct (which hasdouble*arrays, noti8**). The destructured values were treated asi8*string pointers, so any use ofkorv(e.g.console.log(k)) caused a segfault.Fix
Added a guard in
generateMapEntriesForOfthat checks map metadata before generating entries iteration. If the map has no metadata (numeric maps don't storemapMetadata) or the key type isn't"string", the compiler now emits a clear compile error:This is consistent with
method-calls.tswhich already emits compile errors fornumericMap.entries(),numericMap.keys(), andnumericMap.values().Test plan
map-numeric-entries-error.ts(expects compile error)