fix: support class instances and typed arrays returned from function calls#201
Merged
fix: support class instances and typed arrays returned from function calls#201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functions returning class instances or typed arrays (e.g.
KV[]) previously caused segfaults or LLVM errors because the compiler lost type information at the call site.What was broken:
const x = makeObj()wheremakeObj()returns a class → segfault (field access read wrong memory)const tree = buildTree()with self-referential class fields → segfault on deep member accessconst pairs = buildPairs(50)returningKV[]→ LLVM opt error (ptr vs double type mismatch)Root cause: The variable allocator and global variable declarations didn't handle
callexpressions that return class instances or typed arrays — onlynewandmethod_callwere supported.Fix:
allocateClassInstancenow handlescallby looking up the function's return type to determine the class name