fix: emit compile error for global-scope map instead of segfaulting#202
Merged
fix: emit compile error for global-scope map instead of segfaulting#202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
const m = new Map<string, string>(); m.set("k", "v");at the top level (global scope) segfaults at runtime. This is because global maps are stored asglobal %StringMap* null(pointer-to-pointer), butm.set()treats them as direct struct pointers (like localalloca %StringMap). The calling convention mismatch causes memory corruption.Maps inside functions work fine. Sets at global scope also work fine (different allocation path).
Fix
Emit a clear compile error instead of silently generating wrong code:
This is the safe approach — a proper fix would require changing how global map variables are stored and loaded (using an indirection layer), which is a larger change.
Test plan
map-global-scope-error.ts(expects compile error)