perf: optimize charAt comparisons — 1,833x faster character parsing#279
Merged
perf: optimize charAt comparisons — 1,833x faster character parsing#279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getelementptr+load i8+icmpinstead ofGC_malloc_atomic(2)+memcpy+strcmpcs_cached_strlen()caches the last (pointer, length) pair so repeatedstrlen()calls on the same string (the hot path in any parser) return in O(1) instead of O(n)str === "x"uses byte compare instead ofstrcmpBenchmark (JSONC parser, 10K keys / 237KB)
On 2.5MB input: 0.03s (was 55s+ before — 1,833x faster)
Competitive with C (0.005s) and Go (0.01s) on the same workload.
Test plan
string-charat-compare.ts— verifies charAt comparison correctness (in-bounds, OOB, negative index, equality/inequality)🤖 Generated with Claude Code