unskip try-catch-throw and nested ternary tests#281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
try-catch-throw.ts: throw+try-catch now works correctly in the native compiler (was skipped due to duplicate type declarations — resolved by recent fixes)ternary-nested.ts: Nested ternary expressions now work in the native compiler (was skipping due to LLVM 22 crash — resolved by recent alloca-hoisting and codegen fixes)string-for-of.ts: Regression test forfor...ofon strings — verifies character iteration and charCodeAt work correctlyThese were 2 of 21 skipped tests. Both now pass on both JS and native compilers.
Test plan
npm run verify:quickpasses (all tests + Stage 1 self-hosting)🤖 Generated with Claude Code