refactor: decompose generateGlobalVariableDeclarations (794 → 423 lines)#282
Merged
refactor: decompose generateGlobalVariableDeclarations (794 → 423 lines)#282
Conversation
…ch-all handlers from generateGlobalVariableDeclarations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Breaks down the 794-line
generateGlobalVariableDeclarationsmethod into 5 focused helper methods, reducing the main method to ~423 lines. This makes the codegen easier to extend and reduces native compiler miscompilation risk (smaller functions = safer self-hosting).Extracted methods:
tryHandleGlobalCallReturn— function call return type classification (150 lines)tryHandleGlobalJSONParse— JSON.parse interface detection (55 lines)tryHandleGlobalDeclaredType— declared type annotation (interface/class/alias) (65 lines)tryHandleGlobalExpressionType— expression-based interface detection (55 lines)classifyGlobalCatchAll— final type inference from expression node type (45 lines)Test plan
npm run verify:quickpasses (all tests + Stage 1 self-hosting)🤖 Generated with Claude Code