fix(codegen): extend type resolution for call/method chains#523
Merged
Conversation
…, obj.method()[i], and const x = obj.method().field now correctly propagate interface types to prevent garbage reads
Contributor
Benchmark Results (Linux x86-64)
CLI Tool Benchmarks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User impact
More patterns that used to silently read garbage or fail LLVM IR compilation now work correctly:
Context
Part of an ongoing effort to plug gaps in ChadScript's fragmented type-resolution layer. CLAUDE.md rule: ObjectArray element access loses type info. PR #522 added method-call indexed access; this PR extends to free-function indexed access AND `member_access where the object is a method_call or call`.
Change
Fuzz results
Running a 20-case fuzz corpus against the compiler:
Remaining 10 gaps (for future PRs): `.filter()[i]`, `.map(f)[i]`, array-literal indexed, `grid[i][j]`, `arr.find()`, `arr.sort()`, chained inline `x.method().inner.v`, etc.
Test plan