Skip to content

refactor(type-resolver): P3a — delete dead resolveIndexedAccessType #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cs01 wants to merge 1 commit into from
Closed

refactor(type-resolver): P3a — delete dead resolveIndexedAccessType #526

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 0 additions & 33 deletions src/codegen/infrastructure/type-resolver/type-resolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,39 +746,6 @@ export class TypeResolver {
return valueType;
}

resolveIndexedAccessType(expr: IndexAccessNode): ObjectMetadata | null {
const exprObjBase = expr.object as ExprBase;
if (exprObjBase.type !== "member_access") return null;

const memberAccess = expr.object as MemberAccessNode;
const propertyName = memberAccess.property;

let objectInfo:
| { ptr: string; keys: string[]; types: string[]; tsTypes?: string[] }
| undefined;

const memberAccessObjBase = memberAccess.object as ExprBase;
if (memberAccessObjBase.type === "variable") {
const varName = (memberAccess.object as VariableNode).name;
objectInfo = this.ctx.symbolTable.getObjectInfo(varName);
}

if (!objectInfo) return null;

const propIndex = objectInfo.keys.indexOf(propertyName);
if (propIndex === -1) return null;

const tsTypesArr = objectInfo.tsTypes as string[];
const propTsType = tsTypesArr[propIndex];
if (!propTsType) return null;

const arrayParsed = parseArrayTypeString(propTsType);
if (!arrayParsed) return null;

const elementType = arrayParsed.elementType;
return this.getInterfaceMetadata(elementType);
}

detectTypeGuard(condition: Expression): TypeGuardInfo | null {
if (!condition) return null;
if (condition.type !== "binary") return null;
Expand Down
Loading