refactor(type-inference): P3b — member.ts delegates to canonical + revert #521 workaround#527
Merged
refactor(type-inference): P3b — member.ts delegates to canonical + revert #521 workaround#527
Conversation
…elegates to canonical, revert #521 emitError workaround canonical path (rich.arrayDepth>0 + rich.fields) now fires for all indexed-object-array element-field accesses; legacy branches remain as fallback for shapes canonical doesn't yet enrich. with canonical in place, #521's emitError intermediate-variable workaround is no longer necessary — reverted to the original chained method_call+index_access form; native compiler emits the expected diagnostic (no segv). zero fuzz regression; stage 2 self-hosting + fixture suite green.
Contributor
Benchmark Results (Linux x86-64)
CLI Tool Benchmarks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second consumer migration (plan P3b, after #525 P2).
Impact for users
Eliminates a whole chained-expression category of native-compiler segfaults that used to hide behind a mechanical workaround. The underlying type-propagation fix now lives in one place instead of being papered over at call sites.
Test plan