Skip to content

refactor(codegen): migrate array-allocator to typeof() (phase-e step 5, pr2) #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cs01 merged 1 commit into from
Apr 20, 2026
+2 −2
Merged

refactor(codegen): migrate array-allocator to typeof() (phase-e step 5, pr2) #575

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/codegen/infrastructure/array-allocator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export interface ArrayAllocatorContext {
readonly symbolTable: SymbolTable;
emitError(message: string, loc?: SourceLocation, suggestion?: string): never;
getAst(): AST | undefined;
resolveExpressionTypeRich(expr: Expression): ResolvedType | null;
typeOf(expr: Expression): ResolvedType | null;
getArrayStorageStrategy(expr: Expression): "inlined" | "pointer";
}

Expand Down Expand Up @@ -391,7 +391,7 @@ export class ArrayAllocator {
// as an indexed-object-array element — the result is still an array,
// not an element. Short-circuit null so no legacy branch misclassifies
// it as element-info either.
const rich = this.ctx.resolveExpressionTypeRich(indexExpr.object);
const rich = this.ctx.typeOf(indexExpr.object);
if (rich && rich.arrayDepth === 1 && rich.fields) {
return { keys: rich.fields.keys, types: rich.fields.types, tsTypes: rich.fields.tsTypes };
}
Expand Down
Loading