refactor(codegen): drop redundant resolveExpressionType fallback in variable-allocator#592
Merged
refactor(codegen): drop redundant resolveExpressionType fallback in variable-allocator#592
Conversation
…ariable-allocator — typeof already wraps rich resolver (phase-e step 5)
Contributor
Benchmark Results (Linux x86-64)
CLI Tool Benchmarks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
variable-allocator.ts:745-748wheretypeOf()returning null was followed by a second call toresolveExpressionType(). That second call was always null too, becausetypeOfalready wrapsresolveExpressionTypeRich, which wraps the baseresolveExpressionType— if the base is null, rich is null, so typeOf is null.resolveExpressionTypefrom theVariableAllocatorContextinterface entirely — last consumer removed, API surface shrinks.User-facing effect
VariableAllocatorContextis now strictly atypeOf-only consumer, so future callers can't accidentally bypass the annotator cache.Test plan
npm run verify— full tests + 3-stage self-host green locally