Skip to content

[codegen] annotate member-access expressions with class/interface types #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cs01 merged 1 commit into from
Apr 22, 2026
+11 −0
Merged

[codegen] annotate member-access expressions with class/interface types #662

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/semantic/type-annotator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,17 @@ class TypeAnnotator {
}
return;
}
// Member access on a class/interface-typed object. Only cache when the
// resolved type is itself class/interface (avoids disagreeing with
// symbol-table-allocated storage for primitives/arrays/Map/Set).
// Issue #658 gate-loosen step 2.
if (e.type === "member_access") {
const resolved = this.sink.resolveExpressionTypeRich(expr);
if (resolved && this.isSafeVariableAnnotationType(resolved)) {
this.sink.appendExpressionType(expr, resolved);
}
return;
}
// let/const decl bindings and interface-typed params are intentionally
// skipped. Decl bindings can be refined mid-codegen (JSON.parse target
// type, await result specialization); caching the declared type would
Expand Down
Loading